-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: enable core24 plugin tests #5209
Open
sergiusens
wants to merge
22
commits into
main
Choose a base branch
from
work/CRAFT-3138-core24-plugin-spread
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
fdb57a5
tests: create the core24 plugins suite
sergiusens cde70e4
tests: set base to core24 for the plugin suite
sergiusens 2dfb62a
tests: update python interpreter for core24
sergiusens 2f90b1a
tests: update ros2 plugin tests for core24
sergiusens cc26e17
tests: disable python core24 and gnome extension
sergiusens edf6221
tests: reorganize dotnet
sergiusens 1e9facc
tests: remove base setting from core24 plugin test
sergiusens f73ff54
tests: switch core24 plugin suite to run on 22.04
sergiusens 53867c8
chore: update craft parts to 2.3.0
sergiusens 2fee9af
chore: merge main
sergiusens 0e955f9
chore: migrate core24 plugin tests to the suite
sergiusens ae2a07a
chore: migrate npm to build and run for core24
sergiusens 967d57f
tests: run core24 plugin steps individually
sergiusens e85929a
Merge branch 'main' into work/CRAFT-3138-core24-plugin-spread
bepri d4b3da7
tests: add uv tests to core24 plugin suite
bepri 49c5533
tests: use core24 for core24 tests
bepri 22e7808
test: don't use destructive builds for python tests
bepri 3335fc0
Merge branch 'main' into work/CRAFT-3138-core24-plugin-spread
bepri 826973f
test: make python plugin tests run in managed mode
bepri 7ac2f05
Merge remote-tracking branch 'origin/work/CRAFT-3138-core24-plugin-sp…
bepri 3bf9342
Merge branch 'main' into work/CRAFT-3138-core24-plugin-spread
bepri 2e04c38
test: fix python symlink spread tests
bepri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...s/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-jazzy-hello/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
cmake_minimum_required(VERSION 3.5) | ||
project(colcon_ros2_rlcpp_hello) | ||
|
||
# Default to C++14 | ||
if(NOT CMAKE_CXX_STANDARD) | ||
set(CMAKE_CXX_STANDARD 14) | ||
endif() | ||
|
||
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | ||
add_compile_options(-Wall -Wextra -Wpedantic) | ||
endif() | ||
|
||
find_package(ament_cmake REQUIRED) | ||
find_package(rclcpp REQUIRED) | ||
find_package(rclcpp_components REQUIRED) | ||
find_package(std_msgs REQUIRED) | ||
|
||
# This package installs libraries without exporting them. | ||
# Export the library path to ensure that the installed libraries are available. | ||
if(NOT WIN32) | ||
ament_environment_hooks( | ||
"${ament_cmake_package_templates_ENVIRONMENT_HOOK_LIBRARY_PATH}" | ||
) | ||
endif() | ||
|
||
add_executable(colcon_ros2_rlcpp_hello src/hello.cpp) | ||
target_link_libraries(colcon_ros2_rlcpp_hello) | ||
ament_target_dependencies(colcon_ros2_rlcpp_hello rclcpp class_loader) | ||
|
||
install(TARGETS | ||
colcon_ros2_rlcpp_hello | ||
DESTINATION lib/${PROJECT_NAME}) | ||
|
||
ament_package() |
24 changes: 24 additions & 0 deletions
24
tests/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-jazzy-hello/package.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version="1.0"?> | ||
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
<package format="3"> | ||
<name>colcon_ros2_rlcpp_hello</name> | ||
<version>0.0.1</version> | ||
<description>snapcraft test for rlcpp</description> | ||
<maintainer email="[email protected]">me</maintainer> | ||
<license>Apache License 2.0</license> | ||
|
||
<buildtool_depend>ament_cmake</buildtool_depend> | ||
|
||
<build_depend condition="$ROS_VERSION == 2">rclcpp</build_depend> | ||
<build_depend>rclcpp_components</build_depend> | ||
<build_depend>std_msgs</build_depend> | ||
<build_depend condition="$ROS_VERSION == 1">fake_package_that_does_not_exists</build_depend> | ||
|
||
<exec_depend condition="$ROS_VERSION == 2">rclcpp</exec_depend> | ||
<exec_depend>rclcpp_components</exec_depend> | ||
<exec_depend>std_msgs</exec_depend> | ||
|
||
<export> | ||
<build_type>ament_cmake</build_type> | ||
</export> | ||
</package> |
22 changes: 22 additions & 0 deletions
22
...ead/core24-suites/plugins/build-and-run-hello/colcon-ros2-jazzy-hello/snap/snapcraft.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: colcon-ros2-jazzy-hello | ||
version: "1.0" | ||
summary: hello world | ||
description: | | ||
A ROS2 rlcpp-based workspace. | ||
|
||
grade: stable | ||
confinement: strict | ||
base: core24 | ||
|
||
apps: | ||
colcon-ros2-jazzy-hello: | ||
command: opt/ros/jazzy/bin/ros2 run colcon_ros2_rlcpp_hello colcon_ros2_rlcpp_hello | ||
plugs: [network, network-bind] | ||
extensions: [ros2-jazzy] | ||
|
||
parts: | ||
hello: | ||
plugin: colcon | ||
source: . | ||
build-packages: [g++, make, vim] | ||
stage-packages: [ros-jazzy-ros2run] |
28 changes: 28 additions & 0 deletions
28
tests/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-jazzy-hello/src/hello.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2016 Open Source Robotics Foundation, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <memory> | ||
#include "rclcpp/rclcpp.hpp" | ||
|
||
int main(int argc, char * argv[]) | ||
{ | ||
rclcpp::init(argc, argv); | ||
rclcpp::executors::SingleThreadedExecutor exec; | ||
rclcpp::NodeOptions options; | ||
|
||
printf("hello world"); | ||
|
||
rclcpp::shutdown(); | ||
return 0; | ||
} |
34 changes: 34 additions & 0 deletions
34
tests/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-wrapper/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
cmake_minimum_required(VERSION 3.5) | ||
project(colcon_ros2_rlcpp_hello) | ||
|
||
# Default to C++14 | ||
if(NOT CMAKE_CXX_STANDARD) | ||
set(CMAKE_CXX_STANDARD 14) | ||
endif() | ||
|
||
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | ||
add_compile_options(-Wall -Wextra -Wpedantic) | ||
endif() | ||
|
||
find_package(ament_cmake REQUIRED) | ||
find_package(rclcpp REQUIRED) | ||
find_package(rclcpp_components REQUIRED) | ||
find_package(std_msgs REQUIRED) | ||
|
||
# This package installs libraries without exporting them. | ||
# Export the library path to ensure that the installed libraries are available. | ||
if(NOT WIN32) | ||
ament_environment_hooks( | ||
"${ament_cmake_package_templates_ENVIRONMENT_HOOK_LIBRARY_PATH}" | ||
) | ||
endif() | ||
|
||
add_executable(colcon_ros2_rlcpp_hello src/hello.cpp) | ||
target_link_libraries(colcon_ros2_rlcpp_hello) | ||
ament_target_dependencies(colcon_ros2_rlcpp_hello rclcpp class_loader) | ||
|
||
install(TARGETS | ||
colcon_ros2_rlcpp_hello | ||
DESTINATION lib/${PROJECT_NAME}) | ||
|
||
ament_package() |
24 changes: 24 additions & 0 deletions
24
tests/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-wrapper/package.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version="1.0"?> | ||
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
<package format="3"> | ||
<name>colcon_ros2_rlcpp_hello</name> | ||
<version>0.0.1</version> | ||
<description>snapcraft test for rlcpp</description> | ||
<maintainer email="[email protected]">me</maintainer> | ||
<license>Apache License 2.0</license> | ||
|
||
<buildtool_depend>ament_cmake</buildtool_depend> | ||
|
||
<build_depend condition="$ROS_VERSION == 2">rclcpp</build_depend> | ||
<build_depend>rclcpp_components</build_depend> | ||
<build_depend>std_msgs</build_depend> | ||
<build_depend condition="$ROS_VERSION == 1">fake_package_that_does_not_exists</build_depend> | ||
|
||
<exec_depend condition="$ROS_VERSION == 2">rclcpp</exec_depend> | ||
<exec_depend>rclcpp_components</exec_depend> | ||
<exec_depend>std_msgs</exec_depend> | ||
|
||
<export> | ||
<build_type>ament_cmake</build_type> | ||
</export> | ||
</package> |
22 changes: 22 additions & 0 deletions
22
.../spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-wrapper/snap/snapcraft.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: colcon-ros2-wrapper | ||
version: "1.0" | ||
summary: hello world | ||
description: | | ||
A ROS2 rlcpp-based workspace. | ||
|
||
grade: stable | ||
confinement: strict | ||
base: core24 | ||
|
||
apps: | ||
colcon-ros2-wrapper: | ||
command: ros2 run colcon_ros2_rlcpp_hello colcon_ros2_rlcpp_hello | ||
plugs: [network, network-bind] | ||
extensions: [ros2-jazzy] | ||
|
||
parts: | ||
hello: | ||
plugin: colcon | ||
source: . | ||
build-packages: [g++, make, vim] | ||
stage-packages: [ros-jazzy-ros2run] |
28 changes: 28 additions & 0 deletions
28
tests/spread/core24-suites/plugins/build-and-run-hello/colcon-ros2-wrapper/src/hello.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2016 Open Source Robotics Foundation, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <memory> | ||
#include "rclcpp/rclcpp.hpp" | ||
|
||
int main(int argc, char * argv[]) | ||
{ | ||
rclcpp::init(argc, argv); | ||
rclcpp::executors::SingleThreadedExecutor exec; | ||
rclcpp::NodeOptions options; | ||
|
||
printf("hello world"); | ||
|
||
rclcpp::shutdown(); | ||
return 0; | ||
} |
4 changes: 4 additions & 0 deletions
4
tests/spread/core24-suites/plugins/build-and-run-hello/conda-hello/hello
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env ipython3 | ||
|
||
print('hello world') | ||
|
25 changes: 25 additions & 0 deletions
25
tests/spread/core24-suites/plugins/build-and-run-hello/conda-hello/snap/snapcraft.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: conda-hello | ||
version: '1.0' | ||
summary: Hello world using ipython from conda packages | ||
description: | | ||
Leverage conda-packages to install ipython and use it to say "hello world". | ||
|
||
grade: devel | ||
base: core24 | ||
confinement: strict | ||
|
||
apps: | ||
conda-hello: | ||
command: | ||
hello | ||
|
||
parts: | ||
ipython: | ||
plugin: conda | ||
conda-miniconda-version: "py39_4.12.0" | ||
conda-packages: | ||
- ipython | ||
conda-python-version: "3.9" | ||
hello: | ||
plugin: dump | ||
source: . |
16 changes: 16 additions & 0 deletions
16
tests/spread/core24-suites/plugins/build-and-run-hello/flutter-hello/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# flutter_hello | ||
|
||
A new Flutter project. | ||
|
||
## Getting Started | ||
|
||
This project is a starting point for a Flutter application. | ||
|
||
A few resources to get you started if this is your first Flutter project: | ||
|
||
- [Lab: Write your first Flutter app](https://docs.flutter.dev/get-started/codelab) | ||
- [Cookbook: Useful Flutter samples](https://docs.flutter.dev/cookbook) | ||
|
||
For help getting started with Flutter development, view the | ||
[online documentation](https://docs.flutter.dev/), which offers tutorials, | ||
samples, guidance on mobile development, and a full API reference. |
29 changes: 29 additions & 0 deletions
29
tests/spread/core24-suites/plugins/build-and-run-hello/flutter-hello/analysis_options.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# This file configures the analyzer, which statically analyzes Dart code to | ||
# check for errors, warnings, and lints. | ||
# | ||
# The issues identified by the analyzer are surfaced in the UI of Dart-enabled | ||
# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be | ||
# invoked from the command line by running `flutter analyze`. | ||
|
||
# The following line activates a set of recommended lints for Flutter apps, | ||
# packages, and plugins designed to encourage good coding practices. | ||
include: package:flutter_lints/flutter.yaml | ||
|
||
linter: | ||
# The lint rules applied to this project can be customized in the | ||
# section below to disable rules from the `package:flutter_lints/flutter.yaml` | ||
# included above or to enable additional rules. A list of all available lints | ||
# and their documentation is published at | ||
# https://dart-lang.github.io/linter/lints/index.html. | ||
# | ||
# Instead of disabling a lint rule for the entire project in the | ||
# section below, it can also be suppressed for a single line of code | ||
# or a specific dart file by using the `// ignore: name_of_lint` and | ||
# `// ignore_for_file: name_of_lint` syntax on the line or in the file | ||
# producing the lint. | ||
rules: | ||
# avoid_print: false # Uncomment to disable the `avoid_print` rule | ||
# prefer_single_quotes: true # Uncomment to enable the `prefer_single_quotes` rule | ||
|
||
# Additional information about this file can be found at | ||
# https://dart.dev/guides/language/analysis-options |
18 changes: 18 additions & 0 deletions
18
tests/spread/core24-suites/plugins/build-and-run-hello/flutter-hello/flutter_hello.iml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<module type="JAVA_MODULE" version="4"> | ||
<component name="NewModuleRootManager" inherit-compiler-output="true"> | ||
<exclude-output /> | ||
<content url="file://$MODULE_DIR$"> | ||
<sourceFolder url="file://$MODULE_DIR$/lib" isTestSource="false" /> | ||
<sourceFolder url="file://$MODULE_DIR$/test" isTestSource="true" /> | ||
<excludeFolder url="file://$MODULE_DIR$/.dart_tool" /> | ||
<excludeFolder url="file://$MODULE_DIR$/.idea" /> | ||
<excludeFolder url="file://$MODULE_DIR$/.pub" /> | ||
<excludeFolder url="file://$MODULE_DIR$/build" /> | ||
</content> | ||
<orderEntry type="sourceFolder" forTests="false" /> | ||
<orderEntry type="library" name="Dart SDK" level="project" /> | ||
<orderEntry type="library" name="Flutter Plugins" level="project" /> | ||
<orderEntry type="library" name="Dart Packages" level="project" /> | ||
</component> | ||
</module> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these tests build destructively?
One argument "pro" using something lower than 24.04 is that it lets us catch failures in classic snaps