Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize sd-nd-wait-online for waiting on DNS servers #535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Jan 14, 2025

Description

networkd: wait-online wait for DNS servers to be assigned

As implemented in systemd (v258):
systemd/systemd#34640

Spec: https://discourse.ubuntu.com/t/spec-definition-of-an-online-system/27838
Follow-up to: #482 #456

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon force-pushed the sd-2011-sd-wait-online-dns branch 3 times, most recently from bd30602 to 53c7bb2 Compare January 14, 2025 11:46
@canonical canonical deleted a comment from github-advanced-security bot Jan 14, 2025
@slyon
Copy link
Collaborator Author

slyon commented Jan 14, 2025

@enr0n and @daniloegea would you mind taking a look at this PR? I'll still keep it as a draft (please don't merge yet), as we need wider availability of the upstream systemd changes, especially in our test runners (i.e. systemd v258+ or backports).

But besides that, the PR should be ready for review and comply with the spec linked above.

Danilo, do you have any clue what's wrong with the CodeQL (cpp) workflow? Just upgrading from v2 to v3 doesn't seem to do the trick.

@slyon slyon requested review from enr0n and daniloegea January 14, 2025 11:51
@slyon slyon force-pushed the sd-2011-sd-wait-online-dns branch 2 times, most recently from 1f35511 to b399d24 Compare February 3, 2025 15:00
@slyon slyon force-pushed the sd-2011-sd-wait-online-dns branch from b399d24 to 5e8a3da Compare February 3, 2025 15:10
@slyon
Copy link
Collaborator Author

slyon commented Feb 3, 2025

The systemd part of this work was landed upstream and backported to https://launchpad.net/ubuntu/+source/systemd/257.2-3ubuntu1, thanks to @enr0n !

I've now finished implementation of the Netplan side and tested it in Ubuntu Plucky (by uncommenting the line after # XXX: Enable extra testing once systemd#34640 is available on the SUT (i.e. systemd v258+). in ethernets.py autopkgtest), so this should be ready for review!

Before merging it, we need to make sure the CI is ready (i.e. systemd v258+ or backport of the feature) and we should also run the full autopkgtest, as described above.

@enr0n WDYT?

@slyon slyon marked this pull request as ready for review February 3, 2025 15:35
@slyon
Copy link
Collaborator Author

slyon commented Feb 4, 2025

This is now included in Ubuntu Plucky: https://launchpad.net/ubuntu/+source/netplan.io/1.1.2-1ubuntu1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant