Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to charmcraft 3 poetry plugin #531

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

carlcsaposs-canonical
Copy link
Contributor

data-platform-workflows and charmcraftcache are migrating from charmcraft 2 to 3 to enable 24.04 based charms & to enable use of the poetry plugin, which fixes several longstanding issues with charmcraft (e.g. canonical/charmcraft#1077)

MiaAltieri
MiaAltieri previously approved these changes Jan 10, 2025
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your work here Carl, I really appreciate it!

charmcraft.yaml Show resolved Hide resolved
Gu1nness
Gu1nness previously approved these changes Jan 13, 2025
Gu1nness
Gu1nness previously approved these changes Jan 13, 2025
MiaAltieri
MiaAltieri previously approved these changes Jan 13, 2025
@carlcsaposs-canonical
Copy link
Contributor Author

ci failures appear to be flaky tests, similar failures to 6/edge ci

@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review January 14, 2025 09:40
@carlcsaposs-canonical carlcsaposs-canonical merged commit 75e7a44 into 6/edge Jan 14, 2025
27 of 30 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the charmcraft-3-migration branch January 14, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants