microcloud: Subnet sharing warning should check interfaces not IPs #522

gabrielmougard · 2024-12-02T14:18:05Z

closes #516

roosterfish

Thanks for moving the existing check from IPs to interfaces. Please have a look at my last comment, I think we should check the other two remaining ifaces as well.

service/lxd_config.go

cmd/microcloud/ask.go

cmd/microcloud/main_init.go

roosterfish · 2024-12-03T15:36:31Z

Not related to the PR but since we have switched the runners to the free ones this error seems to become peristent. It's probably caused by this so I am wondering if the test bed reset is just failing here.

masnax

Looks good, just one suggestion to reduce complexity & prevent having lots of extra fields & types.

cmd/microcloud/ask.go

gabrielmougard · 2024-12-05T10:49:08Z

@masnax @roosterfish I reworked the approach based on #522 (comment)

roosterfish

Hi, just saw I never submitted the review. Please have a look when you find time.

cmd/microcloud/ask.go

cmd/microcloud/preseed.go

cmd/microcloud/main_init.go

roosterfish · 2025-01-07T08:40:36Z

Also requires a rebase now due to the recent CLI changes.

gabrielmougard · 2025-01-07T08:42:39Z

Thanks for the feedback!

gabrielmougard · 2025-01-07T09:39:55Z

@roosterfish updated

cmd/microcloud/main_init.go

cmd/microcloud/ask.go

cmd/microcloud/main_init.go

roosterfish

Thanks for adding the test cases!
The validation still seems to be outputting something else in case of single node MicroCloud. Please have a look at my comments.

cmd/microcloud/ask.go

cmd/microcloud/main_init.go

cmd/microcloud/main_init_test.go

roosterfish

Hi, looks good already, only a few more smaller comments. Let's have a chat tomorrow morning to go through the details and especially around the verbosity.

cmd/microcloud/main_init.go

cmd/microcloud/preseed.go

cmd/microcloud/main_init.go

roosterfish

Hi, thanks for applying the changes we have discussed last week. This looks good to me and resolves the issue about being too verbose and implying something is off.

In my comments there is another small remark on askAddress, some comments on the output formatting (to be in line with the other outputs) and a hint on how to check for the preseed mode during validation.

cmd/microcloud/ask.go

cmd/microcloud/main_init.go

roosterfish · 2025-02-10T16:46:25Z

cmd/microcloud/main_init.go

 		}
+	} else {


Thanks for differentiating between interactive/preseed.
Instead of passing another bool you can just check for c.autoSetup == true to indicate if we are in preseed mode.
We also use this pattern at other places in the code to check whether or not we should output something.

Having said this when in preseed mode the collision warning shouldn't be printed anymore. It isn't consistent and was the reason for logging #516.

cmd/microcloud/main_init.go

cmd/microcloud/ask.go

roosterfish · 2025-02-12T17:21:05Z

Linter errors should disappear after #632 got merged.

roosterfish · 2025-02-13T08:18:04Z

Can now be rebased.

This type will be used to store a variety of subnet informations and which local network interface they will use. This will be used both for configuring MicroCloud but for running validation as well (e.g, interface collisions within a member, subnet collisions between members of a cluster) Signed-off-by: Gabriel Mougard <[email protected]>

This will be needed to get a network interface info from a CIDR subnet notation (e.g, mostly in the case of configuring MicroCloud internal and public networks) Signed-off-by: Gabriel Mougard <[email protected]>

* This introduce the `OVNGeneveNetwork`, `MicroCephPublicNetwork`, `MicroCephInternalNetwork` and `MicroCloudInternalNetwork` instead of `OVNGeneveAddr`, `MicroCephPublicNetworkSubnet`, `MicroCephInternalNetworkSubnet` and MicroCloud internal network information. Signed-off-by: Gabriel Mougard <[email protected]>

This function detect the local shared network interfaces and the global shared subnets. Signed-off-by: Gabriel Mougard <[email protected]>

Signed-off-by: Gabriel Mougard <[email protected]>

… are in preseed or interactive mode * If we are not in preseed, the call the `detectSharedNetworks` that output advanced network info (shared nics within a system for different services, shared subnet accross a cluster, i.e same subnet in multiple machines used for different services) * Else, we use the former approach: check if the OVN underlay and Ceph cluster network is a valid CIDR subnet notation and output a warning if the subnets are shared. Signed-off-by: Gabriel Mougard <[email protected]>

roosterfish

Hi, ran through another set of tests. The formatting of the messages now follows the general standard, thanks.

Those are my open findings:

The list of selected cluster members is now missing an address of the node who runs the initialization

Verify the fingerprint c4e78dfa47ef is displayed on joining systems.

Selected micro01 at 
Selected micro02 at 10.87.144.136
Selected micro03 at 10.87.144.215

Gathering system information ...

The MicroCloud internal network from the joiners doesn't show up in the network detection (even though addresses from the same network are used).
I was under the impression this should be covered by the newly added populateMicroCloudNetworkFromState func. But there seems to be a problem. Maybe related to 4), see below, I'll shortly add a PR to address this.
Also the OVN underlay doesn't show up but it's using the same network:

What subnet (IPv4/IPv6 CIDR) would you like your Ceph internal traffic on? [default=10.87.144.0/24]: 10.87.144.0/24
What subnet (either IPv4 or IPv6 CIDR notation) would you like your Ceph public traffic on? [default=10.87.144.0/24]: 10.87.144.0/24
Configure distributed networking? (yes/no) [default=yes]: yes

Using enp6s0 on micro01 for OVN uplink
Using enp6s0 on micro02 for OVN uplink
Using enp6s0 on micro03 for OVN uplink

Specify the IPv4 gateway (CIDR) on the uplink network (empty to skip IPv4): 10.1.2.1/24
Specify the first IPv4 address in the range to use on the uplink network: 10.1.2.10
Specify the last IPv4 address in the range to use on the uplink network: 10.1.2.100
Specify the IPv6 gateway (CIDR) on the uplink network (empty to skip IPv6): 
Specify the DNS addresses (comma-separated IPv4 / IPv6 addresses) for the distributed network [default=10.1.2.1]: 10.1.2.1
Configure dedicated OVN underlay networking? (yes/no) [default=no]: yes
Using "10.87.144.24" for OVN underlay traffic on "micro01"
Using "10.87.144.136" for OVN underlay traffic on "micro02"
Using "10.87.144.215" for OVN underlay traffic on "micro03"

Checking network configuration ...
Ceph cluster network, Ceph public network, MicroCloud internal network, OVN underlay network sharing network interface enp5s0 on micro01
Ceph cluster network, Ceph public network, OVN underlay network sharing network interface enp5s0 on micro02
Ceph cluster network, Ceph public network, OVN underlay network sharing network interface enp5s0 on micro03
Ceph cluster network, Ceph public network, MicroCloud internal network sharing subnet 10.87.144.24/24

When running microcloud add there isn't any network sharing message. I thought we agreed on only printing it for new cluster members as getting the used networks from already existing members should be another story as it's not straightforward. Has something changed in this regard?
The subnet sharing warning prints an IP from the network instead of the actual network address: Ceph cluster network, Ceph public network, MicroCloud internal network sharing subnet 10.87.144.24/24. But we can fix this separately from your PR as it's falsely populated in askAddress anyway so no blocker.

I have the feeling the PR is almost there it just requires some more testing for consistency.

cmd/microcloud/main_init.go

roosterfish · 2025-02-13T13:26:35Z

To address comment 4) from above #634.

roosterfish · 2025-02-25T09:54:06Z

Requires a rebase now.

gabrielmougard requested a review from roosterfish December 2, 2024 14:18

gabrielmougard force-pushed the fix/subnet-sharing-warning branch 5 times, most recently from 8e01972 to 3c0887c Compare December 2, 2024 18:36

roosterfish requested changes Dec 3, 2024

View reviewed changes

gabrielmougard force-pushed the fix/subnet-sharing-warning branch 2 times, most recently from 9cec54a to eb8c057 Compare December 3, 2024 11:49

gabrielmougard requested a review from roosterfish December 3, 2024 13:16

masnax suggested changes Dec 4, 2024

View reviewed changes

cmd/microcloud/ask.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from eb8c057 to a9f6ca7 Compare December 5, 2024 10:48

roosterfish mentioned this pull request Dec 9, 2024

Update MicroCloud look and feel #505

Merged

roosterfish requested changes Jan 7, 2025

View reviewed changes

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from a9f6ca7 to e93d076 Compare January 7, 2025 09:39

roosterfish requested changes Jan 8, 2025

View reviewed changes

cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

cmd/microcloud/ask.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/subnet-sharing-warning branch 3 times, most recently from 9f57467 to 1a8b231 Compare January 9, 2025 15:10

gabrielmougard requested review from roosterfish and masnax January 10, 2025 11:39

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from 1a8b231 to 94488b6 Compare January 27, 2025 15:55

roosterfish reviewed Jan 28, 2025

View reviewed changes

cmd/microcloud/ask.go Outdated Show resolved Hide resolved

cmd/microcloud/main_init.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from 94488b6 to a3b5fb2 Compare January 29, 2025 15:07

roosterfish requested changes Jan 30, 2025

View reviewed changes

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from 673c61f to 2a49acf Compare February 4, 2025 15:19

roosterfish requested changes Feb 5, 2025

View reviewed changes

gabrielmougard force-pushed the fix/subnet-sharing-warning branch 4 times, most recently from 4da155f to 0e3a8c7 Compare February 10, 2025 16:07

gabrielmougard requested a review from roosterfish February 10, 2025 16:07

roosterfish requested changes Feb 10, 2025

View reviewed changes

roosterfish reviewed Feb 11, 2025

View reviewed changes

cmd/microcloud/ask.go Outdated Show resolved Hide resolved

roosterfish reviewed Feb 11, 2025

View reviewed changes

cmd/microcloud/ask.go Show resolved Hide resolved

roosterfish reviewed Feb 11, 2025

View reviewed changes

cmd/microcloud/ask.go Outdated Show resolved Hide resolved

gabrielmougard force-pushed the fix/subnet-sharing-warning branch 7 times, most recently from 2d08734 to dfdebd6 Compare February 12, 2025 17:09

gabrielmougard added 6 commits February 13, 2025 10:03

service: Introduce the 'FindInterfaceForSubnet' function

4e1a11c

This will be needed to get a network interface info from a CIDR subnet notation (e.g, mostly in the case of configuring MicroCloud internal and public networks) Signed-off-by: Gabriel Mougard <[email protected]>

cmd/microcloud: Add the detectSharedNetworks function

8c6bd0a

This function detect the local shared network interfaces and the global shared subnets. Signed-off-by: Gabriel Mougard <[email protected]>

cmd/microcloud: Add unit tests for detectSharedNetworks

e60b62b

Signed-off-by: Gabriel Mougard <[email protected]>

gabrielmougard force-pushed the fix/subnet-sharing-warning branch from dfdebd6 to 2057603 Compare February 13, 2025 09:04

roosterfish requested changes Feb 13, 2025

View reviewed changes

cmd/microcloud/main_init.go Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

microcloud: Subnet sharing warning should check interfaces not IPs #522

microcloud: Subnet sharing warning should check interfaces not IPs #522

gabrielmougard commented Dec 2, 2024

roosterfish left a comment

roosterfish commented Dec 3, 2024

masnax left a comment

gabrielmougard commented Dec 5, 2024

roosterfish left a comment

roosterfish commented Jan 7, 2025

gabrielmougard commented Jan 7, 2025

gabrielmougard commented Jan 7, 2025

roosterfish left a comment

roosterfish left a comment

roosterfish left a comment

roosterfish Feb 10, 2025

roosterfish commented Feb 12, 2025

roosterfish commented Feb 13, 2025

roosterfish left a comment

roosterfish commented Feb 13, 2025

roosterfish commented Feb 25, 2025

microcloud: Subnet sharing warning should check interfaces not IPs #522

Are you sure you want to change the base?

microcloud: Subnet sharing warning should check interfaces not IPs #522

Conversation

gabrielmougard commented Dec 2, 2024

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish commented Dec 3, 2024

masnax left a comment

Choose a reason for hiding this comment

gabrielmougard commented Dec 5, 2024

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish commented Jan 7, 2025

gabrielmougard commented Jan 7, 2025

gabrielmougard commented Jan 7, 2025

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish Feb 10, 2025

Choose a reason for hiding this comment

roosterfish commented Feb 12, 2025

roosterfish commented Feb 13, 2025

roosterfish left a comment

Choose a reason for hiding this comment

roosterfish commented Feb 13, 2025

roosterfish commented Feb 25, 2025