Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/DNM feat: add public-url config #11

Closed
wants to merge 6 commits into from
Closed

WIP/DNM feat: add public-url config #11

wants to merge 6 commits into from

Conversation

amandahla
Copy link
Collaborator

Applicable spec:

Overview

This PR is not ready to review yet, I'm waiting for the #10

Adds public-url configuration.

"The public URL where the resources are available. The base path is automatically appended to this."
Extracted from the example config.

Rationale

Allow the user to change the public URL if needed.

Juju Events Changes

Module Changes

Library Changes

Checklist

No CH available yet.

@amandahla amandahla requested a review from a team as a code owner September 23, 2024 19:45
@amandahla amandahla marked this pull request as draft September 23, 2024 19:45
Copy link

Test coverage for a460509

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      71      4      8      1    94%   102, 106, 115, 137
----------------------------------------------------------
TOTAL             71      4      8      1    94%

Static code analysis report

Run started:2024-09-23 19:46:51.979079

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 308
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant