Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: Allow PowerFlex pool creation #15086

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

roosterfish
Copy link
Contributor

@roosterfish roosterfish commented Feb 28, 2025

I just found that when running lxd init we have to ask for the mandatory PowerFlex config keys.

Furthermore the creation of new pools on PowerFlex should not be asked as PowerFlex always expects that the storage pool is already set up on PowerFlex by an administrator.

This ensures the necessary questions are being asked when selecting PowerFlex for the default storage pool.
Only the mandatory questions are being asked.
Settings like powerflex.gateway.verify can be set after the initialization if required.
The driver doesn't reach out to the PowerFlex gateway during pool creation.

Signed-off-by: Julian Pelizäus <[email protected]>
@roosterfish roosterfish changed the title Init: Allow Powerflex pool creation Init: Allow PowerFlex pool creation Feb 28, 2025
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should be broken up and pushed down into each storage driver in order for them to acquire the necessary info interactively that each needs.

Otherwise, as we've found, its easy to forget this section, and its getting pretty unwieldy.

@roosterfish
Copy link
Contributor Author

It feels like this should be broken up and pushed down into each storage driver

Right, looks we also require this for Pure? I'll move it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants