lxd/device/proxy: Remove unix socket from host upon proxy device removal #15081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
force-pushed
the
proxy-device-fixes
branch
4 times, most recently
from
2cd415d to
9f56637
Compare
kadinsayani
force-pushed
the
proxy-device-fixes
branch
3 times, most recently
from
1ed8a89 to
e98a073
Compare
kadinsayani
changed the title
…device Fixes canonical#14972. Rather than just kill the proxy process by sending `SIGKILL`, we should also perform any necessary cleanup (removing the created unix socket) since `forkproxy` only performs cleanup steps upon receiving `SIGTERM`. Signed-off-by: Kadin Sayani <[email protected]>
…l upon unix proxy device removal Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
proxy-device-fixes
branch
from
e98a073 to
e00ca72
Compare
simondeziel
reviewed
Feb 28, 2025
| return fmt.Errorf("Could not read pid file: %s", err) | ||
| } | ||
|
|
||
| err = p.Stop() |
There was a problem hiding this comment.
This p.Stop() is where the forkproxy is being sent the KILL signal. Based on our discussions, since the socket was opened with O_CLOEXEC, it shouldn't not be killed but instead TERM'ed to get a chance to do the cleanup?
@tomponline using KILL here seems to mimic what's done in the other fork* helpers but maybe this one warrants a different approach? Or it doesn't and it's OK to do the cleanup "manually" rather than relying on O_CLOEXEC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14972.
Co-authored by @simondeziel.