Daemon: Allow shutdown during startup #15025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wesley Hershberger <[email protected]>
Fixes canonical#14628 Signed-off-by: Wesley Hershberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14628
Launch
d.Init()in a goroutine so that a shutdown signal will immediately cancel theshutdownCtxand triggerd.Stop(). This allows shutting down LXD while it is still starting; it's likely that this introduces some nasty races (including nil pointer derefs 😢 ) ifStop()is called on a partially initialized daemon.However, responding to shutdown signals right away lets the admin bail on Dqlite startup if a clustered LXD server isn't able to achieve quorum. Without this patch, a user who needs to run
lxd recoverwill sit and wait forever for LXD to shut down gracefully.I'm opening this PR mostly to run the test suite against it; still thinking about an appropriate approach for stopping a partially initialized daemon.