Network: Fix OVN ChassisGroupChassisDelete quoting values #14964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave as default nil value. Signed-off-by: Thomas Parrott <[email protected]>
…assisDelete Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-ovn-chassis
branch
from
abf6eaa to
5dbecf2
Compare
tomponline
changed the title
|
Looking forward to switching to libovsdb and avoiding the need for these approaches cc @markylaing ! |
MusicDin
approved these changes
Feb 12, 2025
tomponline
added a commit
that referenced
this pull request
Feb 12, 2025
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Feb 12, 2025
From - canonical/lxd#14956 - canonical/lxd#14904 - canonical/lxd#14964 Signed-off-by: Thomas Parrott <[email protected]>
tomponline
added a commit
to canonical/lxd-pkg-snap
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #14904
I suspected here #14904 (comment) the call to get
ha_chassislist requires both--format=csvto get them onto one line per record, and--data=bareto avoid the output being (double in this case) quoted.This was preventing the previous fix from actually working.
Also moved the zero-length initialised slices back to uninitialised ones, as nil slices can be appended to, and is more in keeping with how we use slices elsewhere.
Also added a test for chassis removal on LXD shutdown.