Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: LXD: Add services APIs and support for copying across services of type lxd (clusters) #14884

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Jan 29, 2025

No description provided.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 29, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from 06209b4 to 0bfbd6f Compare January 29, 2025 23:32
@kadinsayani
Copy link
Contributor Author

kadinsayani commented Jan 29, 2025

The failing CodeQL security check is due to the join token being passed in as user input to the POST /1.0/site/join request - we use the addresses from the join token when calling GetRemoteCertificate. We do the same in lxd init interactive: https://github.com/canonical/lxd/blob/main/lxd/main_init_interactive.go#L175-L190.

@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from 7cbdfa6 to 3783d48 Compare February 4, 2025 21:30
@kadinsayani kadinsayani changed the title LXD: Server side remotes and remote clusters LXD: Sites Feb 4, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from ed12163 to fa78411 Compare February 5, 2025 22:54
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 10 times, most recently from a43ad68 to b5cd7ef Compare February 11, 2025 18:55
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 2 times, most recently from ad2b200 to 64e9639 Compare February 11, 2025 19:24
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from 10eb790 to 2332bdc Compare February 14, 2025 23:11
@kadinsayani kadinsayani changed the title WIP: LXD: Services WIP: LXD: Add services APIs and support for copying across services of type lxd (clusters) Feb 18, 2025
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
…rvice unset` commands

Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants