lxc/completion: Update instance completions to not show server configs (

#14193) Fixes #14189
canonical · Oct 3, 2024 · 62a97d6 · 62a97d6
2 parents d7392ca + 0c3e893
commit 62a97d6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lxc/completion.go b/lxc/completion.go
@@ -214,8 +214,8 @@ func (g *cmdGlobal) cmpInstanceAllKeys(instanceName string) ([]string, cobra.She
 	var keys []string
 	cmpDirectives := cobra.ShellCompDirectiveNoFileComp
 
-	_, instanceNameOnly, _ := strings.Cut(instanceName, ":")
-	if instanceNameOnly == "" {
+	_, instanceNameOnly, found := strings.Cut(instanceName, ":")
+	if instanceNameOnly == "" && found {
 		serverKeys, directives := g.cmpServerAllKeys(instanceName)
 		keys = append(keys, serverKeys...)
 		cmpDirectives = directives
@@ -231,7 +231,7 @@ func (g *cmdGlobal) cmpInstanceAllKeys(instanceName string) ([]string, cobra.She
 	resource := resources[0]
 	client := resource.server
 
-	instance, _, err := client.GetInstance(instanceNameOnly)
+	instance, _, err := client.GetInstance(instanceName)
 	if err != nil {
 		return nil, cobra.ShellCompDirectiveError
 	}