lxc/auth: avoid fmt.Sprintf (slow) and avoid strings.Join twice for CSV

Signed-off-by: Simon Deziel <[email protected]>
canonical · Jan 20, 2025 · 3c312ae · 3c312ae
1 parent 956b107
commit 3c312ae
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lxc/auth.go b/lxc/auth.go
@@ -1594,10 +1594,12 @@ func (c *cmdPermissionList) run(cmd *cobra.Command, args []string) error {
 				var rowsAssigned []string
 				for k, v := range p.entitlementsAssigned {
 					// Pretty format for tables.
-					assignedRow := fmt.Sprintf("%s ==> (%s)", k, strings.Join(v, ", "))
+					var assignedRow string
 					if c.flagFormat == cli.TableFormatCSV {
 						// Machine readable format for CSV.
-						assignedRow = fmt.Sprintf("%s:(%s)", k, strings.Join(v, ","))
+						assignedRow = k + ":(" + strings.Join(v, ",") + ")"
+					} else {
+						assignedRow = k + " ==> (" + strings.Join(v, ", ") + ")"
 					}
 
 					rowsAssigned = append(rowsAssigned, assignedRow)