lxc/file: replace fmt.Sprintf (slow) by strconv.FormatInt

Signed-off-by: Simon Deziel <[email protected]>
canonical · Jan 21, 2025 · 2211e97 · 2211e97
1 parent cf0e333
commit 2211e97
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/lxc/file.go b/lxc/file.go
@@ -289,7 +289,7 @@ func (c *cmdFileCreate) run(cmd *cobra.Command, args []string) error {
 				Length: contentLength,
 				Handler: func(percent int64, speed int64) {
 					progress.UpdateProgress(ioprogress.ProgressData{
-						Text: fmt.Sprintf("%d%% (%s/s)", percent, units.GetByteSizeString(speed, 2)),
+						Text: strconv.FormatInt(percent, 10) + "% (" + units.GetByteSizeString(speed, 2) + "/s)",
 					})
 				},
 			},
@@ -661,9 +661,8 @@ func (c *cmdFilePull) run(cmd *cobra.Command, args []string) error {
 					}
 
 					progress.UpdateProgress(ioprogress.ProgressData{
-						Text: fmt.Sprintf("%s (%s/s)",
-							units.GetByteSizeString(bytesReceived, 2),
-							units.GetByteSizeString(speed, 2))})
+						Text: units.GetByteSizeString(bytesReceived, 2) + " (" + units.GetByteSizeString(speed, 2) + "/s)",
+					})
 				},
 			},
 		}
@@ -950,7 +949,7 @@ func (c *cmdFilePush) run(cmd *cobra.Command, args []string) error {
 				Length: fstat.Size(),
 				Handler: func(percent int64, speed int64) {
 					progress.UpdateProgress(ioprogress.ProgressData{
-						Text: fmt.Sprintf("%d%% (%s/s)", percent, units.GetByteSizeString(speed, 2)),
+						Text: strconv.FormatInt(percent, 10) + "% (" + units.GetByteSizeString(speed, 2) + "/s)",
 					})
 				},
 			},
@@ -1015,9 +1014,8 @@ func (c *cmdFile) recursivePullFile(d lxd.InstanceServer, inst string, p string,
 			Tracker: &ioprogress.ProgressTracker{
 				Handler: func(bytesReceived int64, speed int64) {
 					progress.UpdateProgress(ioprogress.ProgressData{
-						Text: fmt.Sprintf("%s (%s/s)",
-							units.GetByteSizeString(bytesReceived, 2),
-							units.GetByteSizeString(speed, 2))})
+						Text: units.GetByteSizeString(bytesReceived, 2) + " (" + units.GetByteSizeString(speed, 2) + "/s)",
+					})
 				},
 			},
 		}
@@ -1127,8 +1125,8 @@ func (c *cmdFile) recursivePushFile(d lxd.InstanceServer, inst string, source st
 					Length: contentLength,
 					Handler: func(percent int64, speed int64) {
 						progress.UpdateProgress(ioprogress.ProgressData{
-							Text: fmt.Sprintf("%d%% (%s/s)", percent,
-								units.GetByteSizeString(speed, 2))})
+							Text: strconv.FormatInt(percent, 10) + "% (" + units.GetByteSizeString(speed, 2) + "/s)",
+						})
 					},
 				},
 			}, args.Content)