Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning modal for users with restricted permissions that can't read events #1131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 3, 2025

Done

  • Show a warning modal for users with restricted permissions that can't read events

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • open the ui with an oidc user that does not have the viewer permission on a project
    • ensure the warning modal and warnign icon next to the user name in the side navigations are visible

@webteam-app
Copy link

@edlerd edlerd force-pushed the limited-user-modal branch 3 times, most recently from 9a7ac56 to 796b4cd Compare March 3, 2025 17:18
@edlerd edlerd force-pushed the limited-user-modal branch from 796b4cd to 6f2a45f Compare March 4, 2025 07:51
@Kxiru
Copy link
Contributor

Kxiru commented Mar 5, 2025

Screenshots:
image

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Perhaps a rework of the alignment in this area? Vertically center aligning may suffice

@edlerd edlerd force-pushed the limited-user-modal branch from 6f2a45f to acd36dd Compare March 6, 2025 09:53
@edlerd edlerd requested a review from Kxiru March 6, 2025 09:54
@edlerd
Copy link
Collaborator Author

edlerd commented Mar 6, 2025

Perhaps a rework of the alignment in this area? Vertically center aligning may suffice

Making the button "small" seems to have fixed the alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants