Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restricted permissions for storage pool [WD-19339] #1111

Merged
merged 12 commits into from
Feb 21, 2025
Merged

feat: restricted permissions for storage pool [WD-19339] #1111

merged 12 commits into from
Feb 21, 2025

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 14, 2025

Done

  • Graceful handling of storage pools in the UI
  • covered actions documented in the permissions sheet

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Check through the list of actions documented here

@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd reviewed Feb 14, 2025
View reviewed changes
@mas-who mas-who force-pushed the restricted-permissions-storage-pool branch 2 times, most recently from 3054d08 to fda5c05 Compare February 17, 2025 07:19
@mas-who mas-who changed the title feat: restricted permissions for storage pool feat: restricted permissions for storage pool [WD-19339] Feb 17, 2025
@mas-who mas-who force-pushed the restricted-permissions-storage-pool branch 6 times, most recently from 8c99163 to b8fe8c8 Compare February 20, 2025 15:52
MasWho added 11 commits February 21, 2025 09:42
@MasWho
feat: enable storage pool entitlements query
4ea39ca 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
feat: enable storage volume entitlement queries
b8afedd 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
feat: disable delete storage pool button when user has no permission
5d2523d 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
feat: disable create storage pool button when user has no permission
46a8d29 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
feat: disable storage pool configuration for restricted users
a1ee889 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: mock react context for unit tests
5a932af 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: object comparison for values should not be memory based
7895c79 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: split fetchStoragePool into member specific api so that isFineGr…
6845d11 
…ained does not have to be optional

Signed-off-by: Mason Hu <[email protected]>
@MasWho
review: revert config row changes, permissions are checked from insta…
c745638 
…nce permissions PR already

Signed-off-by: Mason Hu <[email protected]>
@MasWho
feat: disable storage pool yaml edit for restricted permissions
6926e81 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
review: review changes
47d5d98 
Signed-off-by: Mason Hu <[email protected]>
@mas-who mas-who force-pushed the restricted-permissions-storage-pool branch from b8fe8c8 to 47d5d98 Compare February 21, 2025 07:44
edlerd
edlerd requested changes Feb 21, 2025
View reviewed changes
edlerd
edlerd requested changes Feb 21, 2025
View reviewed changes
@mas-who mas-who force-pushed the restricted-permissions-storage-pool branch 2 times, most recently from 363f77c to dca6903 Compare February 21, 2025 12:25
edlerd
edlerd previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and code LGTM, tiny nitpicks on the code. Then this seems good to merge from my point of view.

@MasWho
rewview: review changes
782f077 
Signed-off-by: Mason Hu <[email protected]>
@mas-who mas-who force-pushed the restricted-permissions-storage-pool branch from dca6903 to 782f077 Compare February 21, 2025 13:02
@mas-who mas-who requested a review from edlerd February 21, 2025 13:06
edlerd
edlerd approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff :)

@mas-who mas-who merged commit 88ca2c1 into canonical:main Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mas-who @webteam-app @edlerd @MasWho