-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WD-19015] CMS Server Config for maas.machine #1097
Conversation
16317a6
to
825dc74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress on this one! Some comments below.
825dc74
to
f2b7a0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the iteration! Some hints how to get this finished and more generalized below.
19d9de3
to
281d9d0
Compare
@edlerd , Line 64 has a lint error for the use of Stirng(), however this cannot just be replaced to JSON.stringify because it then means that all the non-clustered values that take string input end up having their speech marks included in the Value field when in non-edit mode, and their default setting becomes ' "" ' instead of '-'. I would suggest trying this locally and testing with maas.api.url. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress, the API layer seems all right. Some suggestions to fix the layout in read mode and to simplify a bit more.
9dee7a6
to
713dd0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and QA work nicely, thanks for the changes. Some suggestions to simplify below.
Ideally we make the empty read only state, when no value is set also display "-", to stay consistent with other parts of the app.
713dd0f
to
74db8d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work 👍
74db8d5
to
c75d4c8
Compare
c75d4c8
to
e646dd7
Compare
Signed-off-by: Nkeiruka <[email protected]>
e646dd7
to
8f2f73c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on disabling the cluster settings 👍
Done
Fixes [list issues/bugs if needed]
QA
Screenshots