Gpu: Check that an instance with a CDI GPU device, can be started even after its host abrupty crash and reboot #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmougard
requested review from
tomponline and
simondeziel
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabrielmougard
force-pushed
the
fix/cdi-test-abrupt-reboot
branch
3 times, most recently
from
57deb3f to
69054db
Compare
simondeziel
requested changes
Jan 23, 2025
gabrielmougard
force-pushed
the
fix/cdi-test-abrupt-reboot
branch
from
69054db to
74571d9
Compare
…ed even after its host abrupty crash and reboot Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
fix/cdi-test-abrupt-reboot
branch
from
74571d9 to
d42c42c
Compare
tomponline
reviewed
Feb 3, 2025
There was a problem hiding this comment.
do we need to use a VM for this, isnt one of the points of CDI that we support nesting (such as docker) inside a container, so can we use a nested LXD inside a LXD container to test this crash support?
There was a problem hiding this comment.
yes true, a nested LXD inside a LXD container should work. I'll test that approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: canonical/lxd#14842