Propagate node configuration through kubernetes api #258
Conversation
There was a problem hiding this comment.
great work @berkayoz - did a first pass on the propagation part
| package types | ||
|
|
||
| type NodeConfig struct { | ||
| CloudProvider string `mapstructure:"cloud-provider,omitempty"` |
There was a problem hiding this comment.
no need to pull in mapstructure - just use json
There was a problem hiding this comment.
We can technically use json but wouldn't that mean doing a Marshal and Unmarshal just to convert between map[string]string and NodeConfig. Seems a bit inefficient/hacky imo.
src/k8s/pkg/k8sd/app/hooks_start.go
Outdated
|
|
||
| configController := controllers.NewNodeConfigurationController() | ||
| go configController.Run(s.Context, snap) | ||
|
|
There was a problem hiding this comment.
i'd love us to have an option like --disable-node-configuration-controller in k8sd. Just a note for the future, don't do this just yet
| select { | ||
| case <-ctx.Done(): | ||
| return nil | ||
| default: | ||
| } |
There was a problem hiding this comment.
change the time.Sleep() at the end of the loop with a <-time.After(3 * time.Second) here. This interval should be something larger like 10 seconds (or more?). That way you don't need multiple time.Sleep()s in the loop, and you don't have to wait for sleep to finish to see that the context has been canceled.
There was a problem hiding this comment.
I'm not exactly sure if the interval should be something larger. Mainly 2 concerns:
- The initial start of the controller might be a bit delayed, which increases the time for nodes to settle.
- If for some reason the
Watchfails, it will take 10 seconds to recover
I think a small interval is okay, the only worry I would have is for the failure on getting a kubernetes client when the cluster is not bootstrapped/joined. Especially in the scenario where someone installed the k8s snap and never interacted with it. We would print an error message into the logs every 3 seconds, that can eventually exhaust disk space.
berkayoz
force-pushed
the
KU-489/propagate-node-config
branch
from
595bd5c to
0213732
Compare
|
Added
NodeConfigurationControllerthat handles watching and reconciling arguments on services.Restructured components(functionalities) to reduce code duplication and help with updating node config(
k8sd-configconfigmap)