Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
eaudetcobello committed Feb 20, 2024
1 parent 65b361d commit 54439d5
Showing 1 changed file with 23 additions and 11 deletions.
34 changes: 23 additions & 11 deletions pkg/kine/drivers/generic/generic.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,30 @@ var (
SELECT MAX(rkv.id) AS id
FROM kine AS rkv`

compactRevSQL = `
SELECT MAX(crkv.prev_revision) AS prev_revision
FROM kine AS crkv
WHERE crkv.name = 'compact_rev_key'`

listSQL = fmt.Sprintf(`
SELECT %s
FROM kine AS kv
LEFT JOIN kine kv2
ON kv.name = kv2.name
AND kv.id < kv2.id
WHERE kv2.name IS NULL
AND kv.name >= ? AND kv.name < ?
AND (? OR kv.deleted = 0)
%%s
ORDER BY kv.id ASC
`, columns)
SELECT *
FROM (
SELECT (%s), (%s), %s
FROM kine AS kv
JOIN (
SELECT MAX(mkv.id) AS id
FROM kine AS mkv
WHERE
mkv.name LIKE ?
%%s
GROUP BY mkv.name) AS maxkv
ON maxkv.id = kv.id
WHERE
kv.deleted = 0 OR
?
) AS lkv
ORDER BY lkv.theid ASC
`, revSQL, compactRevSQL, columns)

// FIXME this query doesn't seem sound.
revisionAfterSQL = fmt.Sprintf(`
Expand Down

0 comments on commit 54439d5

Please sign in to comment.