Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some helper tools for viewing saved summaries #744

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add some helper tools for viewing saved summaries #744

wants to merge 1 commit into from

Conversation

dosaboy
Copy link
Member

@dosaboy dosaboy commented Oct 9, 2023

No description provided.

@dosaboy
Copy link
Member Author

dosaboy commented Oct 9, 2023

@nicolasbock id like to hook this up to the bash autocomplete stuff we added in

@nicolasbock
Copy link
Contributor

Yes that sounds good @dosaboy . Do you want me to follow up with a PR on the bash completion scripts after you merge this one?

@nicolasbock
Copy link
Contributor

We need to also review https://code.launchpad.net/~nicolasbock/ubuntu/+source/daily-build/+git/daily-build/+merge/447457 @dosaboy

@dosaboy
Copy link
Member Author

dosaboy commented Oct 10, 2023

We need to also review https://code.launchpad.net/~nicolasbock/ubuntu/+source/daily-build/+git/daily-build/+merge/447457 @dosaboy

ack i totally missed that one

@dosaboy
Copy link
Member Author

dosaboy commented Oct 10, 2023

We need to also review https://code.launchpad.net/~nicolasbock/ubuntu/+source/daily-build/+git/daily-build/+merge/447457 @dosaboy

ack i totally missed that one

merged.

brianphaley
brianphaley reviewed Oct 10, 2023
View reviewed changes
tools/summary/view.py Outdated

PLUGIN_NAMES = ['juju', 'mysql', 'openstack', 'openvswitch', 'system',
'maas', 'kernel', 'kubernetes', 'rabbitmq', 'sosreport',
'storage', 'vault', 'pacemaker']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing lxd.

Also, hotsos/client.py has a similar list, maybe we can just use that?

tools/summary/view.py Outdated
_has_potential_issues.update(
s[plugin]['potential-issues'])

# print("enabled: {}".format(', '.join(sorted(_enabled))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: debug?

@dosaboy
Copy link
Member Author

dosaboy commented Oct 10, 2023

thanks for reviews, im gonna put this back to WIP as it needs some changes

@dosaboy dosaboy marked this pull request as draft October 10, 2023 17:16
@nicolasbock
Copy link
Contributor

It would be nice there was some documentation for what those scripts are doing.

@dosaboy dosaboy force-pushed the add-summary-helpers branch from 5fda435 to 875ab93 Compare March 28, 2024 09:32
@dosaboy dosaboy force-pushed the add-summary-helpers branch 2 times, most recently from b59c09f to 51ed204 Compare January 29, 2025 17:04
@dosaboy dosaboy force-pushed the add-summary-helpers branch from 51ed204 to d9011ef Compare March 3, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianphaley brianphaley brianphaley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosaboy @nicolasbock @brianphaley