-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container continues to run silently when cos-alerter fails #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI's failing because it's checking for the line you removed in rockcraft.yaml
.
Before merging, can you first fix it (pull-request.yaml) by replacing the line:
rock_pkg_version=$(grep -P -o 'cos-alerter==\d+\.\d+\.\d+' rockcraft.yaml | grep -P -o '\d+\.\d+\.\d+')
with
rock_pkg_version=$(grep -P -o -m 1 'version: "\d+\.\d+\.\d+"' rockcraft.yaml | grep -P -o '\d+\.\d+\.\d+')
(note: it's likely gonna fail on this PR again, but at least the next ones will be okay)
I think it's safe to remove the line entirely since this check is already implemented in |
True! Approving :) |
Issue
Fixes #38
Solution
If no configuration file is passed, the code now catches a FileNotFoundError and exits with a non-zero exit status.
Testing Instructions
docker run -p 8080:8080 ghcr.io/canonical/cos-alerter:latest