-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gadget interface validation test plan (BugFix) #1494
Conversation
update ce-oem-automated test plan and gadget interface test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we want to run the after suspend tests?
IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage. |
I don't get it. What will happen if we test them after suspend? |
I mean the snap interfaces are initialized when it is installed. Thus, the interface will not be affected during the suspend and resume process (unlike the kernel driver, which may experience changes or need reinitialization) . So we don't need to have the after-suspend tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 369 369
Lines 39586 39586
Branches 6685 6685
=======================================
Hits 18798 18798
Misses 20077 20077
Partials 711 711 ☔ View full report in Codecov by Sentry. |
update ce-oem-automated test plan and gadget interface test cases
Description
There are two major changes in this PR
ce-oem-gadget-automated
into the nested part ofce-oem-automated
also-after-suspend
flag from the gadget interface tests.Resolved issues
N/A
Documentation
N/A
Tests
Passed the provider validation locally.