Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gadget interface validation test plan (BugFix) #1494

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

stanley31huang
Copy link
Collaborator

update ce-oem-automated test plan and gadget interface test cases

Description

There are two major changes in this PR

  1. include the ce-oem-gadget-automated into the nested part of ce-oem-automated
  2. remove the also-after-suspend flag from the gadget interface tests.

Resolved issues

N/A

Documentation

N/A

Tests

Passed the provider validation locally.

update ce-oem-automated test plan and gadget interface test cases
@stanley31huang stanley31huang added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Sep 23, 2024
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we want to run the after suspend tests?

@stanley31huang
Copy link
Collaborator Author

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

@LiaoU3
Copy link
Contributor

LiaoU3 commented Sep 23, 2024

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

I don't get it. What will happen if we test them after suspend?

@stanley31huang
Copy link
Collaborator Author

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

I don't get it. What will happen if we test them after suspend?

I mean the snap interfaces are initialized when it is installed. Thus, the interface will not be affected during the suspend and resume process (unlike the kernel driver, which may experience changes or need reinitialization) . So we don't need to have the after-suspend tests.

Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stanley31huang stanley31huang merged commit c9f8b03 into main Sep 23, 2024
12 checks passed
@stanley31huang stanley31huang deleted the update-gadget-validation branch September 23, 2024 07:28
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.48%. Comparing base (104c931) to head (bc0a876).
Report is 118 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   47.48%   47.48%           
=======================================
  Files         369      369           
  Lines       39586    39586           
  Branches     6685     6685           
=======================================
  Hits        18798    18798           
  Misses      20077    20077           
  Partials      711      711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants