Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make tariff and condition links configurable #64

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

lanseg
Copy link
Contributor

@lanseg lanseg commented Nov 27, 2024

Now links to the pdf/docs to the tariff information and usage conditions are configurable with config.json

@lanseg lanseg requested a review from jwkaltz November 27, 2024 14:45
@jwkaltz
Copy link
Member

jwkaltz commented Jan 8, 2025

@lanseg is this pull request still relevant, I think the problem has been solved in a different manner?

@lanseg lanseg force-pushed the GSGGR-197-configuration branch from 4de434f to 0fde710 Compare January 9, 2025 12:35
Copy link
Member

@jwkaltz jwkaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lanseg the pull request looks clear to me, but we also need entries in the german language xlf, or not?

@lanseg
Copy link
Contributor Author

lanseg commented Jan 10, 2025

?

German translation is already there - in the messages.de, line 151 and 159

@jwkaltz jwkaltz self-requested a review January 10, 2025 12:58
@lanseg lanseg merged commit 2803474 into master Jan 10, 2025
1 check passed
@lanseg lanseg deleted the GSGGR-197-configuration branch January 10, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants