Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add off method to EventEmitter #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lcjnil
Copy link

@lcjnil lcjnil commented Feb 11, 2019

myme pushed a commit to myme/jsxapi that referenced this pull request Nov 26, 2019
Use parcel to begin with as it's more plug'n play than rollup. Create a
"dist/jsxapi.min.js" and a "dist/jsxapi.js" UMD distribution bundles
exposing the library globally as "jsxapi". Using parcel seems to "just
work".

Issues with Rollup include not properly bundling and distributing node
builtins. In particular we use EventEmitter from "events", which is
possible to have resolved using rollup-plugin-node-builtins. However it
does not seem to be a complete implementation of the node.js original
module:

calvinmetcalf/rollup-plugin-node-builtins#48

We use ".off()", so that's a show-stopper.

Fix cisco-ce#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant