Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom steps marker #555

Merged
merged 21 commits into from
Jan 22, 2024
Merged

Conversation

BartoszKlonowski
Copy link
Member

@BartoszKlonowski BartoszKlonowski commented Nov 24, 2023

This pull request closes #539 closes #240 closes #157 and fixes #514

It brings the custom steps indicator implementation to the Slider:

Android:

CustomSteps-Slider-Example-Android.mp4

iOS:

CustomSteps-Slider-Example-iOS.mp4

@BartoszKlonowski BartoszKlonowski force-pushed the feature/157/slider-steps-indicator branch from 5c256e5 to 5bc56f2 Compare January 12, 2024 13:30
@BartoszKlonowski BartoszKlonowski force-pushed the feature/157/slider-steps-indicator branch from bcb5a78 to 5d9e456 Compare January 19, 2024 14:00
@BartoszKlonowski
Copy link
Member Author

I feel like this is now completely ready.

@BartoszKlonowski BartoszKlonowski merged commit 22f9562 into main Jan 22, 2024
8 checks passed
@galih9
Copy link

galih9 commented Feb 3, 2024

hi, where do i found the documentation about this custom step marker feature?

@galih9
Copy link

galih9 commented Feb 3, 2024

i tried following the example app, but it keep showing

Property 'StepMarker' does not exist on type 'IntrinsicAttributes & SliderProps'.

@BartoszKlonowski
Copy link
Member Author

BartoszKlonowski commented Feb 5, 2024

Hello @galih9, thank you so much for checking!
Can you link how you use the StepMarker prop and the component you pass there?
Although I think I see the mistake in the Slider's code already, your info would still be very helpful 🙏

@rostyslav-broslavskyi
Copy link

rostyslav-broslavskyi commented Feb 14, 2024

@BartoszKlonowski Hello many thanks for such a big feature update 🔥

I want to ask when you plan on releasing this feature into npm?

upd: Maybe you need any help with docs or something like that?

@BartoszKlonowski
Copy link
Member Author

Hello @rostyslav-broslavskyi, thank you very much for asking! :)
Well, I did have the plan to release it on a certain day, but there's much more to release it then I initially noticed, so now I only plan to release it as soon as possible and as soon as it's really ready - polished and bugles.
However, I'm of course still on it.
As for the question for any help - It's always super helpful to hear any feedback, so you are welcome to check out the main branch of this repo and play with the example app. Maybe modify some examples of the custom steps indicator and provide your thoughts (either here, or by creating new issue).
Thank you! 💪

@AyoCodess
Copy link

any progress on this?

@BartoszKlonowski
Copy link
Member Author

@AyoCodess We are in progress o releasing it, once #581 is merged along with minor adjustments the whole feature will be public.
It takes a while to do those tiny step by step, so I'm hoping for a patience on those 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants