Don't trigger empty PRs for Provider Map updates #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cal-itp-mobility-marketplace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thekaveman
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
pre-commitAction to our provider job so that the generated files are formatted in the same commit after it touches them. This will prevent future empty PRs from being created when the only diff is a newline due to formatting, and our pre-commit makes a second commit "undoing" the lack of a newline in the generated code.I left a comment in my changes, but I want to point out that we need to allow the pre-commit step to continue despite failure because it will always fail whenever it formats files. We don't care about it "failing" since it'll have fixed our files already anyway.
Closes #550