Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Secured Cards Memo to Markdown #323

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

allejo
Copy link
Contributor

@allejo allejo commented Apr 1, 2024

Blocked by #322 because this memo also has an image and footnotes. The prior PR sets up the basis for all of that for this PR to inherit in all its glory.

Closes #310

@allejo allejo requested a review from a team as a code owner April 1, 2024 00:37
@allejo allejo requested a review from mrose914 April 1, 2024 00:37
Base automatically changed from feat/pdf-html-min-accounts-memo to main April 8, 2024 20:05
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit c05d65e
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66144e5c4ad9660007727be6
😎 Deploy Preview https://deploy-preview-323--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit f333996
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66144e6d2fc2880008a17c42
😎 Deploy Preview https://deploy-preview-323--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@mrose914 mrose914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@allejo allejo merged commit 6147b67 into main Apr 11, 2024
5 checks passed
@allejo allejo deleted the feat/pdf-html-secured-cards-memo branch April 11, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please create an html for Secured Cards Memo in Resources
3 participants