Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and related issue
WRF domain was trimmed by 10 grid cells for every resolution.
Relevant motivation and context
WRF output needs to be trimmed, because data at the domain edges has weird numerical stuff going on and it takes some time to “relax” onto the domain’s grid.
Per an email conversation with Stefan: we recommend trimming ~10 grid points from the right, left, top, and bottom edges of each domain (d03, d02, and d01). Ideally there will be some investigation for the amount of trimming; this is our best guess right now.
This is what the code does, for 9 km resolution... you can see the untrimmed WRF data (blue) behind the trimmed WRF grid (coolwarm cmap data on top):
WE NEED TO UPDATE THE GUIDANCE BUT I DON'T THINK I'M THE RIGHT PERSON TO DO THAT
How to test
Try retrieving WRF data for the entire domain using climakitae. Make sure it works... and, just review the code using the diff comparison feature.
Type of change
To-Do
_
before the name