Update pull_request_template.md #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicford
approved these changes
Jan 2, 2025
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| - [ ] This change requires a documentation update | ||
| - [ ] None of the above |
There was a problem hiding this comment.
Out of curiosity what would fit in this category?
There was a problem hiding this comment.
haha! something like this PR :) not a new feature, bug fix, or a breaking change
There was a problem hiding this comment.
Ah gotcha, thanks. I can also see package version updates or something of the like here too
elehmer
approved these changes
Jan 3, 2025
removed readthedocs since it should auto-fill if functions are documented using numpy style docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and related issue
I just modified the PR template
Relevant motivation and context
Thought there were a few irrelevant things. Added a few things as well.