-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 0.8 1.2 GWLs into cava_data options #481
Conversation
Waiting on #480 to be merged in. |
Tagging @claalmve for reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 1.2 WL, LOCA2_EC-Earth3-Veg_r5i1p1f1_historical+ssp245 is retrieved.
For 1.2 WL, WRF_EC-Earth3-Veg_r1i1p1f1_historical+ssp370 is returned.
Sorry @nicolejkeeney bad guidance on my part: those simulations listed in the instructions should only be dropped in 0.8°C! All are kept for 1.2 |
Description of PR
Adds historical GWLs as viable options into
cava_data
functionality in thevulnerability_assessment.ipynb
notebook. I also went ahead and changed the language of theanom
parameter inwarming.py
to be clearer, but did not modify the underlying code as to howanom
is calculated.IMPORTANT: I added two new constants to constants.py of which models should not be returned if the warming level is selected as 0.8°C. This should be implemented more broadly across the code base for 0.8°C in general.
How to test:
Example:
To check # of sims:
Summary of changes and related issue
Requested by partners.
Relevant motivation and context
Requested by partners.
Type of change
Definition of Done Checklist
Practical
_
before the nameConceptual