Handel Response codes as exceptions #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 13, 2016 13:09
…omJaxRSResponse method to be catched and handled by Errorhandler
…ay will handle the response as a 200. Keeps old returns as comments, may want these if the framework will implement AWS Lambda Proxy
…gument if the StatusCode isen't a success response 2xx
…ve the entity when error is thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now it can only return 200 responses. See Issue: #11
For the API Gateway to return other respons codes we throw exceptions instead.
Given that the exception's message has the response code the Lambda Error RegEx will get a match and handle it as a response with the recived code.
Drawbacks: This solution won't return the entity body in it's repsonse when exception is thrown.
I don't think this is the a optimal solution. Maybe we should look at AWS Lambda Proxy which will make the lambadaframework less complex and probably able to handle other respons codes and return a entity body with it.
AWS Lambda Proxy