-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EPD 4in2bc support #144
base: main
Are you sure you want to change the base?
Conversation
After this modification colors render correctly. I need to look how to integrate it with current implementation. impl ColorType for TriColor {
const BITS_PER_PIXEL_PER_BUFFER: usize = 1;
const BUFFER_COUNT: usize = 2;
fn bitmask(&self, bwrbit: bool, pos: u32) -> (u8, u16) {
let bit = 0x80 >> (pos % 8);
let mask = match self {
TriColor::Black => (bit as u16) << 8,
TriColor::White => (bit as u16) << 8 | bit as u16,
TriColor::Chromatic => 0u16,
};
(!bit, mask)
}
} |
Also, |
Hello Yurinnick, Thanks for your work, |
Sup guys, any plans on releasing this one? |
@caemor could you provide feedback please? |
Is there any additional work that needs to be done for this to be merged in, or any help needed? I would love to use this on main. |
So... Does it work? Well, mostly. Display works fine as far as I can tell, however color coding is broken. For some reason
4in2bc
uses a completely different scheme than anything implemented.@caemor could you help with extending
TriColor
implementation to match these requirements? I am willing to do it myself, let's just agree on the best way to approach it. Thanks!