Don't add error log when it is ES version conflicts #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
shijiesheng
reviewed
Jan 31, 2025
| @@ -162,6 +156,7 @@ func (p *ESProcessorImpl) bulkAfterAction(id int64, requests []bulk.GenericBulka | |||
| tag.WorkflowRunID(rid), | |||
| tag.WorkflowDomainID(domainID)) | |||
| p.ackKafkaMsg(key) | |||
| continue | |||
There was a problem hiding this comment.
This will miss failure metrics p.scope.IncCounter(metrics.ESProcessorFailures)
There was a problem hiding this comment.
These might not should be considered as failures, the version conflicts I found are caused by the disordered messages from Kafka, which mean we have short workflows, sometimes for example the closed messages published earlier than the upsert workflow execution calls, we will have version conflicts and we ack to prevent retry on purpose.
There was a problem hiding this comment.
We used the taskID as the visibility message version, which can make sure the older messages won't override the newer ones. That is why we got these conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Don't add error logs when es encounters version conflicts or doc already deleted, we will ack these messages
Why?
Log improvement
How did you test it?
Potential risks
Release notes
Documentation Changes