Implement domain deprecate CLI command #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/cli/domainCommands.go
Outdated
| SecurityToken: securityToken, | ||
| }) | ||
| if err != nil { | ||
| if _, ok := err.(*s.EntityNotExistsError); !ok { |
There was a problem hiding this comment.
As call uses types from types package, you should also check agains an error (with same name) from this package.
This was probably copy-paste, in that case could you check if there are any more cases like this?
Shaddoll
force-pushed
the
cli-domain
branch
3 times, most recently
from
9ef867f to
5745415
Compare
yycptt
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement domain deprecate CLI command
Why?
How did you test it?
Potential risks