Feature/ghcr integration #217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixing breaking test * fixing test to search for Type anywhere in the header * fixing task list test * fixing test * fixed one test but broke another * grouping tests to stop leaking state between tests * moving tests to make them run more consistently * making test less flakey * changing test to make more stable * making test more stable * commenting out test. will be fixed as part of history-virtualize-scroll
* fixing breaking test * fixing test to search for Type anywhere in the header * fixing task list test * fixing test * fixed one test but broke another * grouping tests to stop leaking state between tests * moving tests to make them run more consistently * making test less flakey * changing test to make more stable * making test more stable * commenting out test. will be fixed as part of history-virtualize-scroll
just-at-uber
commented
Oct 29, 2020
| @@ -22,6 +22,22 @@ jobs: | |||
| with: | |||
| username: ${{ secrets.CADENCE_WEB_DOCKERHUB_USERNAME }} | |||
| password: ${{ secrets.CADENCE_WEB_DOCKERHUB_TOKEN }} | |||
| repository: ubercadence/web | |||
| repository: justatuber/web | |||
There was a problem hiding this comment.
Need to swap back to ubercadence/web
just-at-uber
commented
Oct 29, 2020
| uses: docker/build-push-action@v1 | ||
| with: | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.CADENCE_WEB_GHCR_PAT }} |
There was a problem hiding this comment.
Need to change back to GITHUB_TOKEN once github supports this.
See here for more information
just-at-uber
commented
Oct 29, 2020
| username: ${{ github.actor }} | ||
| password: ${{ secrets.CADENCE_WEB_GHCR_PAT }} | ||
| registry: ghcr.io | ||
| repository: just-at-uber/cadence-web/web |
There was a problem hiding this comment.
Need to update repository to uber/cadence-web/web once organization has been initialized with ghcr (see here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with integrating with ghcr for docker image uploads.
Some caveats:
PATtoken instead ofGITHUB_TOKEN. github is aware of issue and working on integratingGITHUB_TOKEN(see here)GITHUB_TOKENis fixed.Screenshots
just-at-uber release
just-at-uber packages
