Fix bug in Cadence Web where falsy values do not render correctly (#529)

This change fixes an issue with cadence-web where false/0 values in the activity result do not render correctly. It makes the check for null/undefined in the getJsonStringObject function more explicit.

client/helpers/get-json-string-object.js

@@ -22,8 +22,9 @@
 import getStringElipsis from './get-string-elipsis';
 
 const getJsonStringObject = value => {
-  const jsonStringFull = value ? JSON.stringify(value, null, 2) : '';
-  const jsonStringDisplay = value ? getStringElipsis(jsonStringFull) : '';
+  const jsonStringFull =
+    value !== undefined ? JSON.stringify(value, null, 2) : '';
+  const jsonStringDisplay = getStringElipsis(jsonStringFull);
 
   return {
     jsonStringDisplay,

client/helpers/get-string-elipsis.spec.js

@@ -31,6 +31,14 @@ describe('getStringElipsis', () => {
       expect(output).toEqual('a-short-string');
     });
   });
+  describe('when passed the empty string', () => {
+    it('should return the empty string', () => {
+      const input = '';
+      const output = getStringElipsis(input);
+
+      expect(output).toEqual('');
+    });
+  });
   describe('when passed a string that has a length equal to MAXIMUM_JSON_CHARACTER_LIMIT', () => {
     it('should return a substring of the original string up until the limit and display a message.', () => {
       const input = ''.padEnd(MAXIMUM_JSON_CHARACTER_LIMIT, '_');