reverseproxy: LeastConnSelection policy bug #5610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeastConnSelection policy is always selecting the last upstream in the pool with the least number of active requests, in fact it should select randomly from all the upstreams which have the least number of active request.
Have corrected the implementation of reservoir sampling in the select method of the LeastConnSelection struct.
Here is the link to the issue:
caddy/issues/5609