Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: LeastConnSelection policy bug #5610

Closed
wants to merge 1 commit into from

Conversation

yashkundu
Copy link

LeastConnSelection policy is always selecting the last upstream in the pool with the least number of active requests, in fact it should select randomly from all the upstreams which have the least number of active request.
Have corrected the implementation of reservoir sampling in the select method of the LeastConnSelection struct.
Here is the link to the issue:
caddy/issues/5609

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Yashasvi Kundu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yashkundu yashkundu closed this Jul 1, 2023
@mholt
Copy link
Member

mholt commented Jul 4, 2023

Hi! Thanks for the patch submission. Did you mean to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants