Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Assay categorical patient level filtering - legacy #11381

Conversation

fuzhaoyuan
Copy link
Contributor

Fix #11347
Describe changes proposed in this pull request:

  • Added support for patient-level data counting in GenericAssayDataCounts

  • For patient-level data:

    • Calculate total count using unique patient IDs
    • Only use first sample from each patient for value counts
  • Sample-level counting logic remains unchanged

  • Code refactored to determine counting mode based on patientLevel flag

@dippindots dippindots self-requested a review February 10, 2025 15:43
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@dippindots dippindots added the bug label Feb 10, 2025
@dippindots dippindots merged commit ef72499 into cBioPortal:master Feb 10, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

genie BPC mets data inconsistent between clinical & generic assay - legacy version
2 participants