Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initial multi column sort for DataTable #3509

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

onursumer
Copy link
Member

Related to knowledgesystems/signal/issues/66

Describe changes proposed in this pull request:

  • Just expose the existing functionality of the underlying table lib (react-table)
  • There will be another PR for Signal frontend once we release the latest react-mutation-mapper

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested review from inodb and leexgh November 18, 2020 11:58
@onursumer onursumer force-pushed the initial-multi-column-sort branch 3 times, most recently from 5e6009c to 1d586d0 Compare November 20, 2020 10:34
@onursumer onursumer force-pushed the initial-multi-column-sort branch from 1d586d0 to 8d642df Compare November 20, 2020 17:17
@onursumer
Copy link
Member Author

Failing e2e tests are not relevant, merging.

@onursumer onursumer merged commit d657211 into cBioPortal:master Nov 20, 2020
@onursumer onursumer deleted the initial-multi-column-sort branch November 20, 2020 19:09
@inodb inodb added the cl-package Improvements related to a package label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-package Improvements related to a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants