net/url: implement url encoding (RFC 3986) #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. this becomes quite a bit larger, I have to take a longer look at this one. But for now just a small thing: |
|
Yes, please take your time. I'll change the names in the meantime. |
Implement url percent-encoding and -decoding functions according to RFC 3986. Add unit tests. Link: https://datatracker.ietf.org/doc/html/rfc3986
Add encoding and decoding methods to the Url struct components according to RFC 3986. An Url can be parsed from a String with `new_parse()` or `temp_parse()`. The parsed fields are decoded. The only field that is not decoded is `raw_query`. To access the decoded query values, use `Url.query_values()`. `Url.to_string()` will re-assemble the fields into a valid Url string with proper percent-encoded values. If the Url struct fields are filled in manually, use the actual (un-encoded) values. To create a raw query string, initialize an `UrlQueryValues` map, use `UrlQueryValues.add()` to add the query parameters and, finally, call `UrlQueryValues.to_string()`.
|
It's quite the pity that the non-allocating solution suddenly has so much allocation happening. The whole thing with the query values being separate is because Url wasn't allocating anything too. So now it makes more sense to pull that into URL |
|
I'll close this PR to come up with a better memory model for this approach. |
|
No need to close it. We can discuss improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement url percent-encoding and -decoding functions according to RFC 3986.
Link: https://datatracker.ietf.org/doc/html/rfc3986
An Url can be parsed from a String with
new_parse()ortemp_parse(). The parsed fields are decoded. The only field that is not decoded israw_query. To access the decoded query values, useUrl.query_values().Url.to_string()will re-assemble the fields into a valid Url string with proper percent-encoded values.If the Url struct fields are filled in manually, use the actual (un-encoded) values. To create a raw query string, initialize an
UrlQueryValuesmap, useUrlQueryValues.add()to add the query parameters and, finally, callUrlQueryValues.to_string().CC: @louis77 as discussed on discord and to keep you in the loop.