-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend examples #11
Extend examples #11
Conversation
Not yet tested in VR...
Completely broken - hits loads of errors
throwing this link here, instead of just code comments, so that github hooks it in to that conversation for google and such: n5ro#171 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review just on initial read through, haven't tried examples yet.
Love the examples, great work. I get no reticle on the contraints for ammo page, the way I do on constraints for cannon. Are you aware of that and chose not to do it, or is it an error or oversight? Not a reason to deny the pull request, but nice to have if you were intending it. |
Would also be nice if the examples were separated under 'cannon' and 'ammo' categories. I also feel like the 'attached to cone' in the initial examples for both is pretty awkward... just makes a bad first impression and looks broken. Not saying you should rework that (happy to have it if you are willing), but we should probably do that. Not sure what we should take away from that, but seems like just flipping the cone upside down and having cube on the flat side would be cleaner? Am I alone in thinking this? |
grab now relies on physics colliders.
Did you look at this page? https://diarmidmackenzie.github.io/aframe-physics-system/examples/ I've realized that this page... ... has a link to the non-updated examples here: So maybe that caused some confusion? |
https://diarmidmackenzie.github.io/aframe-physics-system/examples/ammo/constraints.html (see prev. comment, maybe you ended up one one of the non-updated pages due to incorrect absolute link) |
Yes, agreed. I'll try to do something to improve this. |
I'm not able to fully test npm install at this point due to problems with aframe dependencies: aframevr/aframe#5145
Just moving the cone 1m to the left so the 2 objects are near to each other but don't intersect or z-fight makes this look a lot better IMO. I still don't love the example, but I'd rather work on new, better examples, than invest in this one any further... |
I'm sure the incorrect links were the issue. Going to the ammo example now, I get a reticle, but I get broken examples. ...then, after pasting this image and being here, and flipping back to the tab in question, suddenly the example are now working. Interesting. My internet is very slow here today, so that is probably the cause, figured I'll post anyways since it's interesting that that's possible. |
Is there anything left pending before this is ready for merge? |
This PR covers:
Work on this PR has also uncovered a few issues that it has not resolved - these have been raised separately for future investigation. See issues #7, #8, #9, #10
If you want to see a live staged version of all the changes, ahead of this being merged, you can see that here:
https://diarmidmackenzie.github.io/aframe-physics-system/