Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciiext #15

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Asciiext #15

merged 3 commits into from
Jul 26, 2021

Conversation

Zankoku-Okuno
Copy link

There are some more functions that we should talk about moving around, since they relate to text encodings but are in the Data.Bytes module.

@Zankoku-Okuno Zankoku-Okuno changed the title Asciiext WIP: Asciiext Jul 23, 2021
-- To maintain a running state, see 'hFoldLines'.
--
-- Lines are extracted with with 'BC8.hGetLine', which does not document its
-- dectection algorithm. As of writing (bytestring v0.11.1.0), lines are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dectection

@andrewthad
Copy link
Member

Minor typo. Other than that, looks good.

@Zankoku-Okuno Zankoku-Okuno changed the title WIP: Asciiext Asciiext Jul 23, 2021
@Zankoku-Okuno
Copy link
Author

the function to lowercase ascii was moved to Data.Bytes.Text.AsciiExt.toLowerU, which seems to fit the naming conventions better as well as not being a lettersaurus.

@andrewthad andrewthad merged commit 420daa5 into master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants