add async support to wit_component::dummy_module
#1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to round-trip fuzz test using the async ABI(s) as well as the sync one. I've also added corresponding `--async-callback` and `--async-stackful` options to the `component embed --dummy` subcommand for generating dummy modules which use the new ABIs. Note that this currently only generates ultra-minimal, non-functional modules. A real module would import the `task.return` intrinsic with the appropriate signature for each async export, and would presumably use other new intrinsics such as `subtask.drop`, `task.backpressure`, etc. -- not to mention the various `stream.*`, `future.*`, and `error-context.*` intrinsics. For more thorough fuzz testing, we'll want to generate imports for all known intrinsics (although we probably wouldn't do that for `component embed --dummy` modules, since it would be more confusing than helpful. Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to round-trip fuzz test using the async ABI(s) as well as the sync one. I've also added corresponding
--async-callbackand--async-stackfuloptions to thecomponent embed --dummysubcommand for generating dummy modules which use the new ABIs.Note that this currently only generates ultra-minimal, non-functional modules. A real module would import the
task.returnintrinsic with the appropriate signature for each async export, and would presumably use other new intrinsics such assubtask.drop,task.backpressure, etc. -- not to mention the variousstream.*,future.*, anderror-context.*intrinsics. For more thorough fuzz testing, we'll want to generate imports for all known intrinsics (although we probably wouldn't do that forcomponent embed --dummymodules, since it would be more confusing than helpful).