add stream/future/error-context to wit-smith #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Dec 19, 2024
| @@ -893,6 +897,54 @@ impl WitPrinter { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn declare_stream(&mut self, resolve: &Resolve, name: Option<&str>, ty: &Type) -> Result<()> { | |||
There was a problem hiding this comment.
Could this take a non-optional name and an error be generated above if ty.name is none?
There was a problem hiding this comment.
I was following the precedent set by declare_list, declare_option, etc. above, which all take a Option<&str>. Should all of them be changed to non-optional? Or if not, what's different about stream?
There was a problem hiding this comment.
Ah no I didn't realize that's how everything worked. It feels weird to me to have a method that when it doesn't do anything it's silently a bug, but if it's how everything else is there's no need to change just this method.
I had originally thought that code was unreachable for such types, but `wit-smith` taught me otherwise. Signed-off-by: Joel Dice <[email protected]> add stream/future/error-context to wit-smith I had to tweak fuzz/src/wit64.rs because otherwise the old version of `wit-component` it was using choked on these new types. Now we just return early when that happens. Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
wit-smith-stream-etc
branch
from
4483389 to
2ce3a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak fuzz/src/wit64.rs because otherwise the old version of
wit-componentit was using choked on these new types. Now we just return early when that happens.Otherwise, there was just one other failure in the 15+ minutes I've been running the fuzzer: I had neglected to support the new types in
WitPrinter::declare_typethinking it wasn't necessary, but I was wrong.