Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to latest StarlingMonkey #179

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

karthik2804
Copy link
Contributor

@karthik2804 karthik2804 commented Jan 16, 2025

Updates StarlingMonkey to 257fece3b178385f2ec898008ccb951b52e5fce1

@guybedford
Copy link
Collaborator

I've just landed bytecodealliance/StarlingMonkey#187 as well which would be great to include here.

@karthik2804
Copy link
Contributor Author

Will update the PR.

@guybedford guybedford merged commit 8e67356 into bytecodealliance:main Jan 16, 2025
11 checks passed
@karthik2804
Copy link
Contributor Author

@guybedford would be possible to get a new release? Thanks! I am happy to send a bump PR. I assume a patch release would work?

@karthik2804 karthik2804 deleted the bump_starlingmonkey branch January 16, 2025 23:20
@guybedford
Copy link
Collaborator

@karthik2804 ideally we should do a full WASI upgrade first I think, including bytecodealliance/StarlingMonkey#174 to the latest version as well. Or do you need this very urgently?

@tschneidereit
Copy link
Member

@guybedford can you say more about why you want to block a release on a WASI upgrade? AFAICT, we'd not actually make use of any of the new functionality provided by the new WASI version, right?

@guybedford
Copy link
Collaborator

guybedford commented Jan 17, 2025

@tschneidereit ComponentizeJS will merge the StarlingMonkey world imports with the componentized imports, which will result in components importing old WASI versions as well as the new WASI versions for the component being made, without merging, which should be avoided due to import bloat if possible. Not blocking the release just saying I would prioritize avoiding that for a release myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants