Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basePath & regExp now can be configured #9

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

StyleT
Copy link

@StyleT StyleT commented Jul 12, 2015

Now user can specify base path or regular expression

@StyleT
Copy link
Author

StyleT commented Jul 24, 2015

Anyone is here?

@bustardcelly
Copy link
Owner

@StyleT

I appreciate your interest and this PR.

I am currently deciding on the relevance of its improvement for the following reasons:

  1. Would not overriding a basePath to a file essentially mean that you can possibly point it to any file, therefore giving it false-y file hash?
  2. Providing a custom regex would A) cause more developers (and opened issues) having problems with their own faulty regex thinking it is gulp-rev-append issue and B) be better suited for a tool such as gulp-replace

Truthfully, it's Number 2 that really is keeping me from accepting this PR (along with no additional test to ensure that the changes do what they propose). I use gulp-replace quite often and I think it would be a better tool in what this PR may be trying to accomplish.


I do appreciate your work and would like to hear your thoughts to make me change my mind.

I also apologize for the late response; life happens :)

@pasqLisena
Copy link

+1 for the PR! I need it because I am moving the html from the src to the dist folder, and in src there are not the compiled files to which the html refers (I am using typescript and stylus).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants