Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed artifact publishing after updating to AGP 8.x #583

Merged
merged 2 commits into from
Sep 4, 2023
+29 −9
Merged

Fixed artifact publishing after updating to AGP 8.x #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948c1c4
Fixed artifact publishing after updating to AGP 8.x
LachlanMcKee Sep 3, 2023
c04c125
Disabled android-lib javadoc due as a workaround for #582
LachlanMcKee Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@ jobs:
mergeDetektSarif
:plugins:buildPlugins
--continue
- name: Check publication setup
run: >
./gradlew
publishAllPublicationsToOSSRHRepository
publishAllPublicationsToSonatypeSnapshotRepository
--dry-run
--no-parallel
- name: Deploy snapshot
if: env.MAIN_BRANCH == 'true' && github.repository == 'bumble-tech/appyx'
env:
Expand Down Expand Up @@ -72,6 +65,29 @@ jobs:
**/build/reports/
!**/build/reports/dependency-analysis/

publication-verification:
name: Publication verification
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/gradle-build-action@v2
with:
cache-read-only: ${{ env.MAIN_BRANCH != 'true' }}
- name: Check publication setup
run: >
./gradlew
publishAllPublicationsToOSSRHRepository
publishAllPublicationsToSonatypeSnapshotRepository
--dry-run
--no-parallel
- name: Publish locally
run: ./gradlew publishToMavenLocal -Psigning.required=false --no-parallel --continue

instrumentation-tests:
name: Instrumentation tests
runs-on: macOS-latest
Expand Down
6 changes: 5 additions & 1 deletion plugins/publish-plugin/src/main/kotlin/AndroidAppyxPublishPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ internal class AndroidAppyxPublishPlugin : ProjectPlugin() {
publishing {
singleVariant(getComponentName()) {
withSourcesJar()
withJavadocJar()
/**
* Currently not working with Multiplatform plugin and AGP 8+
* https://github.com/bumble-tech/appyx/issues/582
*/
// withJavadocJar()
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/publish-plugin/src/main/kotlin/ProjectPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ internal abstract class ProjectPlugin : Plugin<Project> {
}

private fun SigningExtension.configureSigning() {
isRequired = true
isRequired = project.findProperty("signing.required")?.toString()?.toBooleanStrict() ?: true

sign(project.extensions.getByType(PublishingExtension::class.java).publications)

Expand Down