Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ocs/upstream #3

Merged
merged 67 commits into from
Jun 12, 2024
Merged

Feature/ocs/upstream #3

merged 67 commits into from
Jun 12, 2024

Conversation

saoc90
Copy link
Collaborator

@saoc90 saoc90 commented Feb 6, 2024 •
edited
Loading

  • Merged upstream changes
  • Add OTEL metrics
  • Add news section

thivy and others added 28 commits February 4, 2024 22:03
@thivy
upgrade
0113351
@thivy
Merge pull request #2 from thivy/v2-upgrade
add39d6 
upgrade
@thivy
Update function to handle edge cases
3ad11c6
@thivy
Update function to handle edge cases
8ef0879
@thivy
Refactor data storage in Azure Cosmos DB***
c03937a
@thivy
Merge pull request microsoft#310 from thivy/main
3fdb18d 
azure chat v2 upgrades
@cmenzi @saoc90
Update open-ai-app.yml
f948635
@cmenzi @saoc90
Update open-ai-app.yml
1bb666d
@cmenzi @saoc90
enable ci/cd for dev and prod
5c659c5
@saoc90
Feature/ocs/ai logging (#1)
1592139 
* Add Application Insights Provider

* Change from CRLF to LF

* Change biceps line ending

* Refactor ApplicationInsightsProvider and initializeTelemetry

* Add session parameter to initializeTelemetry function

* Add logger and track metrics for prompt and completion tokens

* Add OpenTelemetry instrumentation for metrics tracking

* Update model encoding to "gpt-4"

* Add OpenTelemetry metrics instrumentation

* Remove cleanup step

* Add chat metrics tracking and token service
@cmenzi @saoc90
set default values
82cef3b
@cmenzi @saoc90
fix
fae70fd
@cmenzi @saoc90
Update open-ai-app.yml
f5ba1d0
@davidxw
Add messages to chat home when null extensions or peronas
fd05a3d
@cmenzi @saoc90
fix
ae66319
@cmenzi @saoc90
Update open-ai-app.yml
2efd6ea
@cmenzi @saoc90
enable ci/cd for dev and prod
d20e3cb
@cmenzi @saoc90
Update open-ai-app.yml
3aee4d5
@davidxw
Add migration instructions for new Azure services
4f5f5d3
@saoc90
Feature/ocs/ai logging (#1)
b6b6663 
* Add Application Insights Provider

* Change from CRLF to LF

* Change biceps line ending

* Refactor ApplicationInsightsProvider and initializeTelemetry

* Add session parameter to initializeTelemetry function

* Add logger and track metrics for prompt and completion tokens

* Add OpenTelemetry instrumentation for metrics tracking

* Update model encoding to "gpt-4"

* Add OpenTelemetry metrics instrumentation

* Remove cleanup step

* Add chat metrics tracking and token service
@cmenzi @saoc90
Update open-ai-app.yml
2cdc777
@cmenzi @saoc90
Update open-ai-app.yml
d20f0bf
@cmenzi @saoc90
enable ci/cd for dev and prod
c30b810
@saoc90
Feature/ocs/ai logging (#1)
b818b7a 
* Add Application Insights Provider

* Change from CRLF to LF

* Change biceps line ending

* Refactor ApplicationInsightsProvider and initializeTelemetry

* Add session parameter to initializeTelemetry function

* Add logger and track metrics for prompt and completion tokens

* Add OpenTelemetry instrumentation for metrics tracking

* Update model encoding to "gpt-4"

* Add OpenTelemetry metrics instrumentation

* Remove cleanup step

* Add chat metrics tracking and token service
@thivy
Merge pull request microsoft#311 from davidxw/main
6ff8264 
Additional migration documentation plus updates to chat home
@saoc90
Merge branch 'microsoft-main' into feature/ocs/upstream
26065f0
@saoc90
Move metrics service
1435f23
@saoc90
Remove unused appInsights resource
a7e5425
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 7, 2024
View reviewed changes
infra/resources.bicep Fixed Show fixed Hide fixed
infra/resources.bicep Fixed Show fixed Hide fixed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
infra/resources.bicep Fixed Show fixed Hide fixed
infra/resources.bicep Dismissed Show dismissed Hide dismissed
@saoc90
feat: Add news articles to ChatHome component
ae5df93 
This commit adds the functionality to display news articles in the ChatHome component. It introduces a new prop `news` to the `ChatHome` component, which accepts an array of `NewsArticleModel` objects. The news articles are fetched using the `FindAllNewsArticles` service.

The `ChatHome` component now renders the news articles section, displaying each article using the `NewsArticle` component. If there are no news articles available, a message indicating so is shown.

This feature enhances the user experience by providing relevant news articles within the chat interface.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2024
View reviewed changes
infra/main.json Dismissed Show dismissed Hide dismissed
infra/main.json Dismissed Show dismissed Hide dismissed
infra/main.json Dismissed Show dismissed Hide dismissed
infra/main.json
"kind": "SpeechServices",
"properties": {
"customSubDomainName": "[variables('speech_service_name')]",
"publicNetworkAccess": "Enabled"

Check failure

Code scanning / templateanalyzer

Use Cognitive Service Private Endpoints. Error

By default, a public endpoint is enabled for Cognitive Services accounts. The public endpoint is used for all access except for requests that use a Private Endpoint. Access through the public endpoint can be disabled or restricted to authorized virtual networks.
Data exfiltration is an attack where an malicious actor does an unauthorized data transfer. Private Endpoints help prevent data exfiltration by an internal or external malicious actor. They do this by providing clear separation between public and private endpoints. As a result, broad access to public endpoints which could be operated by a malicious actor are not required.
infra/main.json Dismissed Show dismissed Hide dismissed
infra/main.json
"name": "[parameters('speechServiceSkuName')]"
}
},
{

Check failure

Code scanning / templateanalyzer

Storage Account minimum TLS version. Error

The minimum version of TLS that Azure Storage Accounts accept for blob storage is configurable. Older TLS versions are no longer considered secure by industry standards, such as PCI DSS.
Storage Accounts lets you disable outdated protocols and enforce TLS 1.2. By default, TLS 1.0, TLS 1.1, and TLS 1.2 is accepted.
infra/main.json Dismissed Show dismissed Hide dismissed
@saoc90
Copy link
Collaborator Author

saoc90 commented Jun 12, 2024

  • Merged upstream changes
  • Add OTEL metrics
  • Add news section

@saoc90 saoc90 merged commit d3c422d into main Jun 12, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saoc90 @thivy @cmenzi @davidxw