Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the migration docs #962

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Extend the migration docs #962

merged 6 commits into from
Aug 14, 2024

Conversation

timostamm
Copy link
Member

No description provided.

@timostamm timostamm requested review from smaye81 and rakuista August 13, 2024 16:49
@@ -2253,8 +2253,65 @@ uses [custom options](#custom-options).

## Migrating from version 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in the 2 lines from the blog post upgrade section regarding Connect-ES and not needing to upgrade if they don't need Editions: https://github.com/bufbuild/buf.build/pull/1813#discussion_r1715575450

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should put the contemporary information in the manual.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I agree...we have a lot of commentary on the blog post :)

timostamm and others added 5 commits August 13, 2024 19:56
Co-authored-by: Carol Gunby <[email protected]>
Co-authored-by: Carol Gunby <[email protected]>
Co-authored-by: Carol Gunby <[email protected]>
Co-authored-by: Carol Gunby <[email protected]>
@timostamm timostamm merged commit f76c9f5 into main Aug 14, 2024
17 checks passed
@timostamm timostamm deleted the tstamm/migrating-update branch August 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants