Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tectonic: lock --web-bundle for reproducible builds #1

Closed
wants to merge 3 commits into from

Conversation

bryango
Copy link
Owner

@bryango bryango commented Jan 1, 2024

Warning

This is a mock pull request for testing and is not yet ready to be upstreamed at the moment.

Description of changes

tectonic: lock --web-bundle for reproducible builds

This PR depends on tectonic-typesetting/tectonic#1132

@bryango bryango force-pushed the tectonic-lock-bundle branch 6 times, most recently from 79f990b to 1416891 Compare January 4, 2024 02:04
@bryango bryango force-pushed the tectonic-lock-bundle branch 2 times, most recently from 4187187 to e54da63 Compare February 6, 2024 03:08
Also, replace `builtins.toFile` with `pkgs.writeText` because the former
blocks the evaluation loop just like an import from derivation (IFD).
Although it is _technically_ not an IFD, it has very similar effects,
and thus we should prefer the nixpkgs `pkgs.writeText` instead.
@bryango bryango force-pushed the tectonic-lock-bundle branch from e54da63 to 246662a Compare February 6, 2024 03:23
@bryango
Copy link
Owner Author

bryango commented Feb 6, 2024

Finalized, ready to be upstreamed.

@bryango bryango closed this Feb 6, 2024
bryango pushed a commit that referenced this pull request Feb 22, 2024
Since ba83271 the build fails with

    applying patch /nix/store/46rxbbvl2l3mrxb50y9rzy7ahgx0lraj-d741901dddd731895346636c0d3556c6fa51fbe6.patch
    patching file tests/hazmat/primitives/test_aead.py
    Hunk #1 FAILED at 56.
    Hunk #2 FAILED at 197.
    Hunk #3 FAILED at 378.
    Hunk #4 FAILED at 525.
    Hunk #5 FAILED at 700.
    Hunk #6 FAILED at 844.
    6 out of 6 hunks FAILED -- saving rejects to file tests/hazmat/primitives/test_aead.py.rej
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants